Re: Make accidental styles available as context mods. (issue 4819064)

[Neil Puttock]

On 5 September 2011 17:21,  <address@hidden> wrote:
> LGTM.

Thank you. :)

> http://codereview.appspot.com/4819064/diff/1/lily/parser.yy
> File lily/parser.yy (right):
>
> http://codereview.appspot.com/4819064/diff/1/lily/parser.yy#newcode670
> lily/parser.yy:670: continue;
> What exactly is the reason for this hardcoded workaround? Somehow I
> don't get your comment in the patch description...

Since David has also queried this, I'll reply below.

> http://codereview.appspot.com/4819064/diff/1/ly/context-mods-init.ly
> File ly/context-mods-init.ly (right):
>
> http://codereview.appspot.com/4819064/diff/1/ly/context-mods-init.ly#newcode30
> ly/context-mods-init.ly:30: (cdr style-settings))))))
> I don't see any way around the lambda functions displayed for
> make-accidental-style...

It's rather unfortunate, since it really defeats the object of having
documentation.  I suppose the only alternative would be avoid currying
and have several specific rule functions.

Cheers,
Neil