Re: contributing instructions are misleading!

[Graham Percival]

On Wed, Dec 11, 2013 at 10:20:22PM -0500, Carl Peterson wrote:
> I was able to connect to git with minimal fuss, and currently
> use the lily-git.tcl tool to handle commits and patches.

Great!  This suggests that the introduction in the CG is ok.

>    All that said, where things got interesting for me was when I wanted to
>    figure out how to submit my patch. Following through the directions in 2.2
>    (lily-git), I got to this text:
>    > Send patch files to the appropriate place:
>    >
>    > * If you have a mentor, send it to them via email.
>    > * New contributors should send the patch attached to an email to
>    address@hidden Please add a**[PATCH]a** to the subject line.
>    > * Translators should send patches to address@hidden
>    > * More experienced contributors should upload the patch for web-based

Right.  From memory, I think there's 3 different sets of
instructions for submitting a patch in the CG.  2 of them contain
factually incorrect information, and 1 of them was correct as of
summer 2012.  That one is probably still correct, but I wouldn't
feel comfortable vounching for it.

Fixing this doesn't require a reorganization.  It requires
deleting the two incorrect bits, dumping a @ref{Submitting a
patch} or whatever the @node is called.  On a similar note,
there's at least 2 "checklists before submitting a patch", at
least 1 of which has obsolete info.

... come to think of it, the whole "mentor" infrastructure never
got off the ground, so there *is* misleading info in chapter 1.

- Graham