lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Staging broken.


From: David Kastrup
Subject: Re: Staging broken.
Date: Wed, 19 Feb 2020 17:30:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

David Kastrup <address@hidden> writes:

> Han-Wen Nienhuys <address@hidden> writes:
>
>> On Wed, Feb 19, 2020 at 9:19 AM Han-Wen Nienhuys <address@hidden> wrote:
>>
>>>
>>>> +// Necessary for supporting pango_context_new() and
>>>> +// pango_context_set_font_map() in Pango < 1.22
>>>> +#define PANGO_ENABLE_BACKEND
>>>> +
>>>>
>>>
>>> ..
>>
>>> I'm preparing a docker image for my lilypond-ci scripts that lets me check
>>> for this case too.
>>>
>>
>> I did this, see
>>
>> https://github.com/hanwen/lilypond-ci/commit/145e1e0dcf61c74ff3278ebb1a0fedda17f08056
>>
>> it reproduces the failure. I added a fix, and verified it passes on Ubuntu
>> 19.04.
>>
>> I pushed it to staging.
>>
>> There should be a cleaner way than defining PANGO_ENABLE_BACKEND, but don't
>> have time to investigate now.
>
> Could you explain the urgency warranting an immediate hotfix bypassing
> all review, feedback and proper solution-finding?

Moved this to dev/pango branch for now so that we have a chance to
discuss this.

-- 
David Kastrup
My replies have a tendency to cause friction.  To help mitigating
damage, feel free to forward problematic posts to me adding a subject
like "timeout 1d" (for a suggested timeout of 1 day) or "offensive".



reply via email to

[Prev in Thread] Current Thread [Next in Thread]