Re: Staging broken.

[Jonas Hahnfeld]

Am Donnerstag, den 20.02.2020, 20:21 +0100 schrieb David Kastrup:
> Jonas Hahnfeld <
> address@hidden
> > writes:
> 
> > Am Mittwoch, den 19.02.2020, 17:30 +0100 schrieb David Kastrup:
> > > David Kastrup <
> > > address@hidden
> > > 
> > > > writes:
> > > > Han-Wen Nienhuys <
> > > > address@hidden
> > > > 
> > > > > writes:
> > > > > On Wed, Feb 19, 2020 at 9:19 AM Han-Wen Nienhuys <
> > > > > address@hidden
> > > > > 
> > > > > > wrote:
> > > > > > > +// Necessary for supporting pango_context_new() and
> > > > > > > +// pango_context_set_font_map() in Pango < 1.22
> > > > > > > +#define PANGO_ENABLE_BACKEND
> > > > > > > +
> > > > > > > 
> > > > > > 
> > > > > > ..
> > > > > > I'm preparing a docker image for my lilypond-ci scripts that lets 
> > > > > > me check
> > > > > > for this case too.
> > > > > > 
> > > > > 
> > > > > I did this, see
> > > > > 
> > > > > https://github.com/hanwen/lilypond-ci/commit/145e1e0dcf61c74ff3278ebb1a0fedda17f08056
> > > > > 
> > > > > 
> > > > > 
> > > > > it reproduces the failure. I added a fix, and verified it passes on 
> > > > > Ubuntu
> > > > > 19.04.
> > > > > 
> > > > > I pushed it to staging.
> > > > > 
> > > > > There should be a cleaner way than defining PANGO_ENABLE_BACKEND, but 
> > > > > don't
> > > > > have time to investigate now.
> > > > 
> > > > Could you explain the urgency warranting an immediate hotfix bypassing
> > > > all review, feedback and proper solution-finding?
> > > 
> > > Moved this to dev/pango branch for now so that we have a chance to
> > > discuss this.
> > 
> > For the record, you seem to have pushed to commits to staging -> master
> > again, right?
> 
> Yes.  Han-Wen and I had an off-list discussion about the impact of the
> changes, and they are at least not a regression in respect to the
> previous state we had, even if they cannot reduce the number of warnings
> in newer versions of Pango to zero while still supporting a range of
> older versions.

May I ask to have such discussion on-list for the next time? That's why
we have a lilypond-devel, right?

Jonas

signature.asc
Description: This is a digitally signed message part