Re: Staging broken.

[Han-Wen Nienhuys]

On Tue, Feb 18, 2020 at 11:08 PM David Kastrup <address@hidden> wrote:

> Han-Wen Nienhuys <address@hidden> writes:
>
> > This surprises me greatly. I just checked
> > out b16c3d14f3d1f10aa919e70107e6103c67a9aa01 which is what I pushed this
> > morning,  and I can execute
> >
> >  ./autogen.sh ; make -j4
> >
> > just fine. In fact, I actually did test this before pushing this morning.
> >
> > Could it be that you forgot to run autogen.sh ?
>
> lilypond-patchy-staging starts from a fresh directory, so no.  It
> wouldn't get anywhere without running autogen.sh.
>

The build log talks about

autogen.sh --noconfigure

can you confirm that with "   ./autogen.sh && make -j4" it also fails?

I cannot vouch for all software versions being the same as yours,
> obviously.
>

Can you provide me with some recipe to reproduce the problem? Can you tell
me what distribution you use? I could use Docker to recreate your setup.


> Did you run make clean ?
>

I ran from a clean checkout as well.


> Versions installed here:
>
> ii  libpango1.0-dev:amd64      1.42.4-7        amd64        Development
> files for the Pango
>
> Also libguile-1.8, but I consider it unlikely that this changes the used
> include files.
>
> You removed several defines that I think Werner added at some point of
> time in order to deal with newer versions of Freetype.
>
> I read in the patch:
>
>  AC_DEFUN(STEPMAKE_PANGO_FT2, [
>      PKG_CHECK_MODULES(PANGO_FT2, $1 >= $3, have_pangoft2=yes, true)
>      if test "$have_pangoft2" = yes ; then
> -        AC_DEFINE(HAVE_PANGO16)
> -        AC_DEFINE(HAVE_PANGO_FT2)
>          # Do not pollute user-CPPFLAGS with configure-CPPFLAGS
>          save_CPPFLAGS="$CPPFLAGS"
>          save_LIBS="$LIBS"
> @@ -1328,8 +1300,6 @@ AC_DEFUN(STEPMAKE_PANGO_FT2_WITH_OTF_FEATURE, [
>      PKG_CHECK_MODULES(PANGO_FT2, $1 >= $3,
>          have_pangoft2_with_otf_feature=yes, true)
>      if test "$have_pangoft2_with_otf_feature" = yes; then
> -        AC_DEFINE(HAVE_PANGO16)
> -        AC_DEFINE(HAVE_PANGO_FT2)
>          AC_DEFINE(HAVE_PANGO_FT2_WITH_OTF_FEATURE)
>
>
> Any reason for that?
>

HAVE_PANGO16 was unused.

I effectively made HAVE_PANGO_FT2 always be true.

-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen