lwip-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-users] typo in src/core/pbuf.c:770


From: Bob Ammerman
Subject: Re: [lwip-users] typo in src/core/pbuf.c:770
Date: Wed, 26 Mar 2003 10:09:50 -0800

How 'bout:
 
Change:
 
...printf("blah blah %p blah blah", myptr)
 
To:
 
...printf("blah blah " LWIP_POINTER_FORMAT " blah blah", LWIP_POINTER_CAST myptr)
 
With:
 
#define LWIP_POINTER_FORMAT "%p"
#define LWIP_POINTER_CAST
 
or
 
#define LWIP_POINTER_FORMAT "%lx"
#define LWIP_POINTER_CAST (unsigned long)
 
Bob Ammerman
RAm Systems
 
----- Original Message -----
Sent: Wednesday, March 26, 2003 4:28 AM
Subject: Re: [lwip-users] typo in src/core/pbuf.c:770


> BTW some compilers (or better some embedded libc) do not support the %p
> format specifier.
> Wouldn't it better to use %x instead ?
> GP
>


Better would be that %p is supported in the compiler. We do not always
want lwIP to adapt to the largest common denominator of all develop
tools out there.

The output of %p looks like %lx on some common platforms, but
on uC's with page/segment/offset based addressing schemes.

Maybe the question must be: to what C standard do we adhere?


Regards,

Leon Woestenberg


_______________________________________________
lwip-users mailing list
address@hidden
http://mail.nongnu.org/mailman/listinfo/lwip-users

reply via email to

[Prev in Thread] Current Thread [Next in Thread]