Re: [Monotone-devel] status of release 1.1

[Thomas Keller]

Markus Wanner schrieb:
> On 05/03/2014 11:46 PM, Thomas Keller wrote:
>> I'm running a 64 bit OS X and your test program reports "mktime seems okay".
> 
> Thanks. Surprises me. Although: I had a time zone issue in that test
> program itself, though.
> 
> I could finally arrange for an Mac OS X box (Mountain Lion) that
> thankfully reproduced the issue. I'm just about to commit a fix.
> Attached a corrected variant of the test code. On my Mac OS X box it
> yields: Lower boundary wrong (got -1)

Yep, I get this as well. Just after I've sent my previous mail I looked
at the unit-test's code again and spotted this:

  // this is the valid range of dates supported by 32 bit time_t
  date_t start("1901-12-13T20:45:52");
  date_t end("2038-01-19T03:14:07");

So I guess the timestamp that it supposed to handle
("1901-12-13T20:45:51") should not be acceptable with a 32 bit time_t
and it should fail in such a case. But yeah, I'm just scratching on the
surface, you're way more fluent and faster than me in this area :)

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature