Re: proposed patch for bootstrap

[Bruce Korb]

On 04/06/11 09:50, Gary V. Vaughan wrote:
> > I'd suggest a couple of tweaks:
> >
> > 1.  gnulib_non_module_files ought to be dependent upon not being set
> >      by bootstrap.conf (as is the case), but also $build_aux.
> >      if configure.ac or bootstrap.conf changes it, this variable will
> >      not be correct.
> Could you explain that in a bit more detail, I don't yet understand what
> you mean.

Your variation:
gnulib_non_module_files="
        build-aux/compile
        build-aux/install-sh
        build-aux/missing
        build-aux/mdate-sh
        build-aux/texinfo.tex
        build-aux/depcomp
        build-aux/config.guess
        build-aux/config.sub
        doc/INSTALL
"

So the "build-aux" directory is hard wired in your version,
likely as a consequence of being derived from a hard wired original.
Now, it uses a variable:

  gnulib_extra_files="
        $build_aux/install-sh
        $build_aux/missing
        $build_aux/mdate-sh
        $build_aux/texinfo.tex
        $build_aux/depcomp
        $build_aux/config.guess
        $build_aux/config.sub
        doc/INSTALL
"

and yesterday I pushed a fix to do that assignment after bootstrap.conf
has had an opportunity to change the value of $build_aux.

> > 2.  Perhaps just my preference, but the embedded README/usage/help
> >      text feels like too much clutter that belongs in associated
> >      doc files rather than filling the first several hundred lines
> >      of the script.  :)
>
> Oh, absolutely... that was never meant to live in the file, but to be

Just checking.  :)

> Moloch:~ gary$ cd Devo/coreutils--master--0
> Moloch:coreutils--master--0 gary$ ./bootstrap
> bootstrap: `./bootstrap' differs from `./gnulib/build-aux/bootstrap',
> bootstrap: please consider adopting the canonical version from gnulib.
> bootstrap: Error: `xz' not found
> bootstrap: Error: `autoconf' version == 2.61 is too old
> bootstrap:        `autoconf' version>= 2.62 is required
> bootstrap: Error: `automake' version == 1.10 is too old
> bootstrap:        `automake' version>= 1.11.1 is required
> bootstrap: Error: `gettext' not found
> bootstrap: Error: README-prereq explains how to obtain these bootstrap programs:
> bootstrap:        Program    Min_version Homepage
> bootstrap:        -----------------------------------------------------------
> bootstrap:        bison      -           http://www.gnu.org/software/bison
> bootstrap:        git        1.4.4       http://git-scm.com
> bootstrap:        gperf      -           http://www.gnu.org/software/gperf
> bootstrap:        makeinfo   -           http://www.gnu.org/software/texinfo
> bootstrap:        perl       5.5         http://perl.com
> bootstrap:        rsync      -           http://www.samba.org/rsync
> bootstrap:        tar        -           http://www.gnu.org/software/tar
> bootstrap:        xz         -           http://tukaani.org/xz
> bootstrap:        autoconf   2.62        http://www.gnu.org/software/autoconf
> bootstrap:        automake   1.11.1      http://www.gnu.org/software/automake
> bootstrap:        gettext    0.18        http://www.gnu.org/software/gettext
> bootstrap:        -----------------------------------------------------------

*WOW* !!!  Error messages done right!  _Really_ cool.

> Anyway, I'm rambling... If there are any non-time-sucking things I can
> do to help shepherd this patch into gnulib, I would be very happy to
> see it adopted, to encourage its use in gnulib client projects, and to
> help maintain it.

I'm still unemployed, so I have some time for time sucking things,
but I also get distracted with other odds and ends and, of course,
pushing my resume around.  :(

Cheers :) - Bruce