[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: proposed patch for bootstrap
From: |
Gary V. Vaughan |
Subject: |
Re: proposed patch for bootstrap |
Date: |
Thu, 7 Apr 2011 11:21:02 +0700 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Howdy Bruce!
On Wed, Apr 06, 2011 at 10:28:28AM -0700, Bruce Korb wrote:
> On 04/06/11 09:50, Gary V. Vaughan wrote:
> >>1. gnulib_non_module_files ought to be dependent upon not being set
> >> by bootstrap.conf (as is the case), but also $build_aux.
> >> if configure.ac or bootstrap.conf changes it, this variable will
> >> not be correct.
>
> [[...]]
>
> So the "build-aux" directory is hard wired in your version,
> likely as a consequence of being derived from a hard wired original.
> Now, it uses a variable:
>
> gnulib_extra_files="
> $build_aux/install-sh
> $build_aux/missing
> $build_aux/mdate-sh
> $build_aux/texinfo.tex
> $build_aux/depcomp
> $build_aux/config.guess
> $build_aux/config.sub
> doc/INSTALL
> "
>
> and yesterday I pushed a fix to do that assignment after bootstrap.conf
> has had an opportunity to change the value of $build_aux.
Ah, gotcha. Yes, all true. The change to my bootstrap script is simple
enough, although non-trivial because the build-aux in $gnulib_extra_files
currently doubles up as a path into the gnulib tree when pulling files
into the client project (IIRC). It just means stepping carefully through
the the script and looking at each instance of 'build-aux' to decide
whether it refers to the client tree or the gnulib tree, and perhaps a
little code to disambiguate where it is used for both meanings at the
same time.
Unless there are objections, I'd suggest commiting my bootstrap on a new
topic branch in the upstream repo for easier collaboration and testing.
> >If there are any non-time-sucking things I can
> >do to help shepherd this patch into gnulib, I would be very happy to
> >see it adopted, to encourage its use in gnulib client projects, and to
> >help maintain it.
>
> I'm still unemployed, so I have some time for time sucking things,
> but I also get distracted with other odds and ends and, of course,
> pushing my resume around. :(
Good luck with the job hunting, I'll keep an ear to the ground too.
If you'd like to fix up the build-aux issue in the mean time that would
be awesome! Although, might be worth waiting for a thumbs up from a
core gnulib maintainer who has no moral objections to an eventual merge
to master of this version of bootstrap before you sink any serious
effort into it...
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
pgptKG52sMrGJ.pgp
Description: PGP signature
- proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Eric Blake, 2011/04/05
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Eric Blake, 2011/04/05
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/05
- Re: proposed patch for bootstrap, Gary V. Vaughan, 2011/04/06
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/06
- Re: proposed patch for bootstrap, Gary V. Vaughan, 2011/04/06
- Re: proposed patch for bootstrap, Bruce Korb, 2011/04/06
- Re: proposed patch for bootstrap,
Gary V. Vaughan <=