Re: [Gnu-arch-users] bad permissions when adding revisions to the library

[Pau Aliagas]

On Tue, 23 Dec 2003, Jan Hudec wrote:

> On Tue, Dec 23, 2003 at 14:10:46 +0100, Pau Aliagas wrote:
> > On Tue, 23 Dec 2003, Jan Hudec wrote:
> > 
> > > On Tue, Dec 23, 2003 at 13:50:19 +0100, Pau Aliagas wrote:
> > > > On Tue, 23 Dec 2003, Jan Hudec wrote:
> > > > 
> > > > > > I'm not sure that tla preserves the setuid bits, in fact I think it 
> > > > > > does 
> > > > > > not. But anyway I'm talking about permissions that are commited to 
> > > > > > the 
> > > > > > archive and lost afterwards.
> > > > > 
> > > > > You have all directories in your working tree with setgid bits set???
> > > > 
> > > > Yes, I commit the changes with all the dirs g+s but they are not kept 
> > > > when 
> > > > adding revisions to the library. That is a problem when you want to 
> > > > share 
> > > > a directory to keep revision available for a devel group.
> > > 
> > > Now, that is a bug in arch. Arch should either:
> > > - Remember the suid & sgid bits and restore them apropriately.
> > > - Leave suid & sgid bits alone, leaving them in whatever state system
> > >   created them. Thus if parent dir is sgid, new directories should
> > >   remain sgid.
> > 
> > That's what I expected :) but neither happened. Only when adding the 
> > parent directories up to the patch-level the setuid bit was honoured, but 
> > when the revision was extracted and added to the library the setuid bits 
> > were lost.
> 
> Hm... there is one more issue -- the revision is first created in
> temporary directory somewhere and then moved in place. I am not sure
> where that temporary directory is created. If it does not have the sgid
> bit...

It's created in the same location with a ,,new-revision* name. Here is 
where the problem lays.

Pau