lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CG chapter 2, first draft


From: Graham Percival
Subject: Re: CG chapter 2, first draft
Date: Wed, 13 Jan 2010 12:20:28 +0000

On Wed, Jan 13, 2010 at 8:16 AM, Mark Polesky <address@hidden> wrote:
> Okay, here's a patch.  Obviously, there's more work to be done,
> but it might be good to get the re-structuring stuff out of the
> way.  `make' succeeded and `make doc' is still going, but I'm off
> to bed.

Looks mostly good.

- you've reverted some of the ``foo'' -> @qq{foo} changes in essay.  Why?

- I'm not positive, but I believe that we put punctuation outside @q{}
brackets.  If you want to change this policy, we can discuss it, but
please don't just go changing things inside the hu/ translation.


- are you certain you can have `quotes' in @node names?  Also, please
use @q{} in the @section name.
... actually, could we just sidestep the whole issue by removing the
quotes entirely?  "@node Using lily-git" seems easy enough for me.

- elsewhere in the docs, we use "foo -- bar", not "foo---bar".  I
don't pretend to be authoritative about the difference, though.

- the FIXME in Making patches can be removed, I think.

- Advanced git concepts: I suggest simply pointing at the "other git
documentation" node, instead of discussing the Git Community Book
here.

- pushing to `blah blah': again, I'm not wild about the quotes.  Also,
I'd suggest changing it to "Pushing to origin"; that way, if the git
url ever changes, we don't need to change the node name, any refs that
point to it, and any links to the online docs.  The latter is fairly
unlikely, even if we include mailing list archives... but I think it's
still a good idea to make the node names as stable as possible.


If you want to push this patch and change other items later, I'm happy
with that -- as long as you remove the changes to hu/ and essay/ from
this patch.  They're a separate matter, and shouldn't be rolled into
such a big change.

Cheers,
- Graham




reply via email to

[Prev in Thread] Current Thread [Next in Thread]