[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: an example of minimal example (issue4636082)
From: |
lemniskata . bernoullego |
Subject: |
Re: an example of minimal example (issue4636082) |
Date: |
Mon, 04 Jul 2011 21:01:44 +0000 |
New patch set uploaded.
2011/7/4 <address@hidden>:
I'm glad that you're working on it! I'm just warning you that there
will be many nitpicks.
No problem. If they aren't about code style, i can handle them :)
http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):
http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi#newcode275
Documentation/web/community.itexi:275: Is the code below a minimal
example?
On 2011/07/04 20:24:56, Graham Percival wrote:
This is way too long. I spent a lot of time and effort making the
website as
minimal as possible to increase readability
I had this feeling too.
Hmm... I'd be ok with it if you put it in a box at the bottom of the
page. I
actually can't believe that we don't have any examples on the Tiny
examples page
-- the only place to find something is on the Bug reports page!
Done (at least i hope that it's written correctly).
http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi#newcode277
Documentation/web/community.itexi:277: @lilypond
On 2011/07/04 20:24:56, Graham Percival wrote:
this won't compile; it would have to be @example instead, and that
will require
@{ @} escapes.
Umm.. is it right now?
http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi#newcode346
Documentation/web/community.itexi:346: using less than a single measure.
On 2011/07/04 20:24:56, Graham Percival wrote:
I prefer "only". If somebody gets it down to 1 measure, we're not
going to
quibble about 2 beats vs. 4 beats.
Umm, James' original example was exactly one measure, and we condemned
it as being too long.
2011/7/4 James Harkins <address@hidden> wrote:
To me, one bar is tiny.
And after all, this wording doesn't force people to make examples less
then one measure at all costs. It only suggests things.
http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi#newcode353
Documentation/web/community.itexi:353: 2 lines of code, and few exceed
10 lines.
On 2011/07/04 20:24:56, Graham Percival wrote:
Hmm. I'm worried that this (combined with the next item) would make
the page
too wordy. Leave it in there for the next draft, but I may complain
about it
later.
I moved it to the bottom box, how do you like it?
http://codereview.appspot.com/4636082/
- an example of minimal example (issue4636082), lemniskata . bernoullego, 2011/07/04
- Re: an example of minimal example (issue4636082), pkx166h, 2011/07/04
- Re: an example of minimal example (issue4636082), lemniskata . bernoullego, 2011/07/05
- Re: an example of minimal example (issue4636082), percival . music . ca, 2011/07/06
- Re: an example of minimal example (issue4636082), lemniskata . bernoullego, 2011/07/06
- Re: an example of minimal example (issue4636082), percival . music . ca, 2011/07/07