lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)


From: milimetr88
Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)
Date: Wed, 25 Apr 2012 11:49:03 +0000


http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc
File lily/ledger-line-spanner.cc (left):

http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68
lily/ledger-line-spanner.cc:68: while (flip (&d) != DOWN);
On 2012/04/25 11:47:07, Milimetr88 wrote:
On 2012/04/25 09:57:48, dak wrote:
> This was a _one_-iteration loop.  After the change, it is a
_two_-iterations
> loop.

In http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46279
Keith asked me
to change that in a separate commit, so I did so. Did he wanted me to
do
something else?

Ah, sorry - a mistake. The third patch set was about something else. Ok,
I'll make a commit without correcting this loop.

http://codereview.appspot.com/6109046/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]