Re: stencils: let some stencils carry a box-extent; issue 3255 (issue 9295044)

[dak]

On 2013/06/13 16:40:46, dak wrote:

https://codereview.appspot.com/9295044/diff/51001/scm/define-markup-commands.scm
> File scm/define-markup-commands.scm (right):


https://codereview.appspot.com/9295044/diff/51001/scm/define-markup-commands.scm#newcode1913
> scm/define-markup-commands.scm:1913: #:properties (pad-around-markup)
> Remove this #:properties line.  It makes no sense whatsoever.

Having read the documentation of define-markup-command, I have to take
back the "makes no sense whatsoever".  Could not remember that bit for
the life of me.  I am not sure we are using this elsewhere, and it would
pretty certainly require pad-around-markup to be defined before
pad-markup-markup.  But you are using this definitely according to
instructions.

I think it would likely be worth checking whether replacing this fixes
the compilation problem: the sort of bookkeeping that is done here uses
weak hashtables, so the error message you got would be consistent with a
problem in this area.  If that proves to be the case, I'd volunteer for
more thorough research into this: I am afraid that this code might be my
responsibility to a good degree.

https://codereview.appspot.com/9295044/