monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] 0.48 rants


From: Thomas Keller
Subject: Re: [Monotone-devel] 0.48 rants
Date: Sun, 18 Jul 2010 01:05:36 +0200
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5

Am 17.07.10 23:55, schrieb Stephen Leake:
> "Aaron W. Hsu" <address@hidden> writes:
> 
>> As a question, can I alter what is committed through the changelog
>> editor? 
> 
> No.

Basically, the problem is that its quite easy to create an invalid
revision if you remove apparently "unrelated" changes, which in the end
would make your commit fail (e.g. [ "add file", "add attribute on file"
], "add attribute on file" can be removed, "add file" not if the
attribute change is not removed as well, or think about renames and
adds, ... stuff like that).

So we'd need an additional validation cycle. This is easier doable in
GUIs like guitone than on command line, where you have to parse the
(changed) changeset, validate it, notice its broken and re-open the
editor again.

>> Normally, my workflow goes something like: status to see
>> what has changed; diff to see those individual changes; a series of
>> commits to commit the pieces in the way that I want. 
> 
> You can do this with Emacs DVC. I don't know about Guitone.

You can only restrict before, but I had this on my todo list sometime
for guitone.

> You can do it from the command line with the --exclude argument and by
> specifying files directly. 
> 
> So we _could_ extend the commit editor to do this, by providing fields
> that are the file args (allowing Unix shell wildcards would be best) and
> the --exclude arg.

If somebody would work on that, I'd rather let the user directly change
the changeset in the editor, but not the possible command line
restrictions which led to the changeset.

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]