Re: [Adonthell-devel] Rewriting C++ base code

[Pélisson Fabien]

Hi,

OK for gfx.h inclusions, i don't still have a global vision of all the
differents components (still looking in some parts of gfx).

I give you another patch with some minors modifications (in fact only in
drainwg_area).

I have also a question :
Why do the surface& operator=(const surface&) method pure virtual ?
Then in all the derived class you have to dynamic cast the parameter to
the current class without knowing its type.
example in surface_SDL : 
surface& surface_sdl::operator=(const surface& src)
{
  const surface_sdl& src_sdl = (const surface_sdl &) src;
  ....
}
if someone make a surface_gdk :
class surface_gdk : public surface
{
...};
and then write
surface_gtk sg;
surface_sdl sd;
...
sd = sg; // cast surface_gtk => surface_sdl.

Perhaps overloading operator= (idem for copy) methods is preferable ?
 
Thanks for comments,

Fabien.

adonthell-0.4.patch
Description: Text Data