RE: [External] : Concern about new binding.

[Drew Adams]

> In a recent commit I see that the C-x g binding was taken for
> revert-buffer.
> 
> I suppose this should have been discussed previously, unless I don't
> find the thread... but I have some concerns about this.
> 
> 1) In general `C-x g` is used by magit; I know this is not a priority
> (cause magit is an external package), but magit is a very popular
> package.
> 
> 2) In some threads before we have discussed that relative short
> combinations must be reserved to maps in order to economize them...
> 
> 3) In spite of revert-buffer is a very useful command it is useless in
> many conditions like when auto-revert-mode is enable... so maybe it
> makes sense to bind it to something longer (ex: C-x g r)??
> 
> There are more commands that could be set in a map inside C-x g IMHO:
> toggle-read-only revert-buffer-with-fine-grain something to
> enable/disable font-lock etc
> 
> This way instead of limiting; could open a big spot to set useful
> commands. I understand that longer commands are harder to discover, but
> hopefully we could have which-key in the next release?
> 
> I hope I am writing this soon enough that the author could consider
> revert this change maybe with something more "general" does it makes
> sense??

See attached mails, and the thread for bug #46151.
I end that second mail saying this:

  All proposals to sacrifice keys to default bindings
  should really be discussed on emacs-devel.

The first mail reiterates the reasons I oppose this
binding.
> --- Begin Message ---
>
>
>
> Subject: 
>
> bug#46151: [External] : bug#46151: 28.0.50; Set revert-buffer-function in shell command output buffers
>
>
>
>
> Date: 
>
> Mon, 1 Feb 2021 16:14:13 +0000
>
>
>
>
> > I think a global `revert-buffer' binding is the way to go.  How to
> > reload a file is something that comes up all the time, so I think it is
> > high time it got bound.
>
> I disagree, for reasons given before:
>
> 1. Anyone who wants it can bind it.  (I do.)
>
> 2. It has no meaning for many modes.  By its
>    very nature it is essentially mode-specific.
>
> 3. Modes where it is useful typically already
>    bind it.  And they bind it to a key that
>    makes sense for that particular mode.
>    You just need to use `C-h m' to find out
>    what the key is.
>
> 4. Given #3, if you add a global binding for
>    it then there's not much point in those
>    mode-specific bindings.
>
> 5. Emacs has been fine for 35+ years without
>    any global binding for it.  The "Founders"
>    knew what they were doing in this regard.
>    (Perhaps they were thinking of some of this
>    list.)
>
> 6. Emacs should impose a moratorium on itself
>    NOW, to stop binding keys by default.  Just
>    say NO.
>
>    Seriously.
>
>    The few keys that still have no default
>    global bindings should be left as is, in
>    general - left for users and 3rd-party code.
>
> 7. IF many users start using some binding over
>    a period of years THEN Emacs can consider
>    giving it a default binding.  Don't be
>    prematurely "optimizing" UI in this way for
>    people when there has been no popular
>    request for it.
>
> 8. YAGNI.
>
> One opinion.
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> bug#46151: [External] : bug#46151: 28.0.50; Set revert-buffer-function in shell command output buffers
>
>
>
>
> Date: 
>
> Mon, 1 Feb 2021 19:43:11 +0000
>
>
>
>
> > > I think a global `revert-buffer' binding is the way to go.  How to
> > > reload a file is something that comes up all the time, so I think it
> > > is high time it got bound.
> > 
> > Okay, here is a patch.
>
> Please don't do this.  Don't remove `C-x g' from
> the little remaining virgin (non-default) key
> territory.
>
> It is not "high time" to bind this or any other
> key by default.  It's high time to _desist_ from
> having default Emacs taking over more territory.
> It doesn't need it, and it shouldn't take it.
>
> 35 years with no global binding for `revert-buffer'.
> No problem - thousands of users and hackers.  But
> now, from one user request Lars decides it's "high
> time"...  No need.
>
> All proposals to sacrifice keys to default bindings
> should really be discussed on emacs-devel.
>
>
>
>
> --- End Message ---