Re: [Monotone-devel] bugfest analysis

[Thomas Keller]

Am 10.05.10 05:23, schrieb Timothy Brownawell:
> On 05/09/2010 06:28 PM, Thomas Keller wrote:
> 
>> * #17878: Usability: too easy to accidentally fork after
>>    merge or disapprove
>>    ->  branch is net.venge.monotone.bugfest-2010.17878-tbrownaw
>>    ->  @Tim: is this done?
> 
> It needs a test using the --update option, which I'll get to either in
> the morning or after work tomorrow. I suppose I should also put a note
> in NEWS about setting your get_default_command_options() if you want to
> always have that behavior.

Looks cool so far, a few minor questions / nitpicks:

1) In maybe_workspace_updater.cc:
+    if (rev.edges.size() != 1)
+      return not_updatable;

Wouldn't that mean that the root revision of a branch is not updatable?
I.e. create a new project, commit and push that. Somebody else changes
it, you pull with --update afterwards, or do I get something wrong?

2) "Your workspaces have not been updated" - why are you using plural here?

Thomas.

-- 
GPG-Key 0x160D1092 | address@hidden | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en

signature.asc
Description: OpenPGP digital signature